This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24016 ) Change subject: trx_toolkit/data_msg.py: update entries in enum Modulation ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/24016/2/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/24016/2/src/target/trx_toolkit/data_msg.py@40 PS2, Line 40: ModAQPSK = (0b1100, 2 * GMSK_BURST_LEN) Hi Philipp, thanks for review and for checking it carefully! > ... for ModAQPSK the left side has 0b0110 and the right side has 0b1100 as index (?). It took me some time to realize that you mean what was before this patch and after. Good catch, but actually this is expected. I had to change coding of ModAQPSK to allow up to 4 TSC sets. Please see: https://git.osmocom.org/osmo-gsm-manuals/commit/?id=f14fb4b949860d81c732cbc6d3e1f60dbb2ecb45 I am sorry for not making this clean in the commit description, will update it soon. Maybe I should even split this change into a few smaller ones... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia96b263bbb162b6c40f2cf81616118cc297299a5 Gerrit-Change-Number: 24016 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 04 May 2021 12:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210504/8e2678ea/attachment.htm>