Change in osmocom-bb[master]: trx_toolkit/test_codec.py: add missing sub-test with key=0x88

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue May 4 12:45:40 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24108 )

Change subject: trx_toolkit/test_codec.py: add missing sub-test with key=0x88
......................................................................

trx_toolkit/test_codec.py: add missing sub-test with key=0x88

Change-Id: If8e2ebedc48fecc4c54c71e40cadb0f3273602c5
---
M src/target/trx_toolkit/test_codec.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/target/trx_toolkit/test_codec.py b/src/target/trx_toolkit/test_codec.py
index e0649d8..ca2f773 100644
--- a/src/target/trx_toolkit/test_codec.py
+++ b/src/target/trx_toolkit/test_codec.py
@@ -54,6 +54,10 @@
 			field = TestField('magic')
 			self.assertEqual(field.to_bytes(vals), encoded_de)
 
+		with self.subTest('default length=4, different key=0x88'):
+			field = TestField('magic', key=0x88)
+			self.assertEqual(field.to_bytes(vals), encoded_88)
+
 		with self.subTest('different length=2, default key=0xde'):
 			field = TestField('magic', len=2)
 			vals['magic'] = vals['magic'][:2]

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24108
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If8e2ebedc48fecc4c54c71e40cadb0f3273602c5
Gerrit-Change-Number: 24108
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210504/13c75be3/attachment.htm>


More information about the gerrit-log mailing list