Change in osmocom-bb[master]: trx_toolkit/data_msg.py: update entries in enum Modulation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue May 4 10:03:19 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24016 )

Change subject: trx_toolkit/data_msg.py: update entries in enum Modulation
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

There seems to be a problem...

https://gerrit.osmocom.org/c/osmocom-bb/+/24016/2/src/target/trx_toolkit/data_msg.py 
File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/24016/2/src/target/trx_toolkit/data_msg.py@40 
PS2, Line 40: 	ModAQPSK	= (0b1100, 2 * GMSK_BURST_LEN)
I have re-calculated the factors for the burst length. They seem to be correct, but for ModAQPSK the left side has 0b0110 and the right side has 0b1100 as index (?). To me this looks like an error.

ModGMSK  = (0b0000, 148) => 1 * GMSK_BURST_LEN
Mod8PSK  = (0b0100, 444) => 3 * GMSK_BURST_LEN
ModAQPSK = (0b0110, 296) => 2 * GMSK_BURST_LEN (0b0110 != 0b1100)
Mod16QAM = (0b1000, 592) => 4 * GMSK_BURST_LEN
Mod32QAM = (0b1010, 740) => 5 * GMSK_BURST_LEN



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24016
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia96b263bbb162b6c40f2cf81616118cc297299a5
Gerrit-Change-Number: 24016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 04 May 2021 10:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210504/0c8245d8/attachment.htm>


More information about the gerrit-log mailing list