Change in osmocom-bb[master]: trx_toolkit/trxd_proto.py: fix encoding of TRXDv0 Tx PDUs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon May 3 14:16:51 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24013 )

Change subject: trx_toolkit/trxd_proto.py: fix encoding of TRXDv0 Tx PDUs
......................................................................

trx_toolkit/trxd_proto.py: fix encoding of TRXDv0 Tx PDUs

Change-Id: I9da59f7e7c47dd1cac833839165ba05de6b18144
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/trxd_proto.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/target/trx_toolkit/trxd_proto.py b/src/target/trx_toolkit/trxd_proto.py
index 7afa484..ded0336 100644
--- a/src/target/trx_toolkit/trxd_proto.py
+++ b/src/target/trx_toolkit/trxd_proto.py
@@ -125,9 +125,10 @@
 
 class PDUv1Tx(PDUv0Tx):
 	# Same structure as PDUv0Tx, only the version is different
-	def __init__(self, *args, **kw):
-		PDUv0Tx.__init__(self, *args, **kw)
-		self.STRUCT[0]._fields[0].val = 1
+	STRUCT = (
+		Header(ver=1),
+		*PDUv0Tx.STRUCT[1:]
+	)
 
 
 class PDUv2Rx(codec.Envelope):

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24013
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9da59f7e7c47dd1cac833839165ba05de6b18144
Gerrit-Change-Number: 24013
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/286597ac/attachment.htm>


More information about the gerrit-log mailing list