Change in gr-gsm[master]: grgsm_livemon: Specify localhost as string

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ptrkrysik gerrit-no-reply at lists.osmocom.org
Mon May 3 10:24:41 UTC 2021


Hello vvvelichkov,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/gr-gsm/+/24071

to review the following change.


Change subject: grgsm_livemon: Specify localhost as string
......................................................................

grgsm_livemon: Specify localhost as string

Traceback (most recent call last):
  File "/home/vasko/gr38/lib/python3.7/dist-packages/gnuradio/grc/core/FlowGraph.py", line 216, in renew_namespace
    value = eval(parameter_block.params['value'].to_code(), namespace)
  File "<string>", line 1, in <module>
NameError: name 'localhost' is not defined

Change-Id: I6bae2fb1f09038cb0cd3410533d3b3fdc79ed354
---
M apps/grgsm_livemon.grc
M apps/grgsm_livemon_headless.grc
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/71/24071/1

diff --git a/apps/grgsm_livemon.grc b/apps/grgsm_livemon.grc
index a11b243..941f816 100644
--- a/apps/grgsm_livemon.grc
+++ b/apps/grgsm_livemon.grc
@@ -179,7 +179,7 @@
     label: IP or DNS name of collector point
     short_id: ''
     type: str
-    value: 'localhost'
+    value: '"localhost"'
   states:
     bus_sink: false
     bus_source: false
diff --git a/apps/grgsm_livemon_headless.grc b/apps/grgsm_livemon_headless.grc
index 27d43b8..f4d5945 100644
--- a/apps/grgsm_livemon_headless.grc
+++ b/apps/grgsm_livemon_headless.grc
@@ -134,7 +134,7 @@
     label: IP or DNS name of collector point
     short_id: ''
     type: str
-    value: 'localhost'
+    value: '"localhost"'
   states:
     bus_sink: false
     bus_source: false

-- 
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24071
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: I6bae2fb1f09038cb0cd3410533d3b3fdc79ed354
Gerrit-Change-Number: 24071
Gerrit-PatchSet: 1
Gerrit-Owner: ptrkrysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: vvvelichkov <vvvelichkov at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/cc7cc561/attachment.htm>


More information about the gerrit-log mailing list