Change in pysim[master]: [pylint] Mark abstract MagicSimBase class as such

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun May 2 00:56:50 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24028 )


Change subject: [pylint] Mark abstract MagicSimBase class as such
......................................................................

[pylint] Mark abstract MagicSimBase class as such

Change-Id: I315c646d94a1d3282917f5abb0c93efb918b53d7
---
M pySim/cards.py
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/28/24028/1

diff --git a/pySim/cards.py b/pySim/cards.py
index 3b53654..24e789e 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -23,6 +23,7 @@
 #
 
 from typing import Optional, Dict, Tuple
+import abc
 
 from pySim.ts_51_011 import EF, DF, EF_AD
 from pySim.ts_31_102 import EF_USIM_ADF_map
@@ -470,7 +471,7 @@
 				uiari_recs += "UICC IARI: Can't read, response code = %s\n" % (sw)
 		return uiari_recs
 
-class _MagicSimBase(Card):
+class MagicSimBase(abc.ABC, Card):
 	"""
 	Theses cards uses several record based EFs to store the provider infos,
 	each possible provider uses a specific record number in each EF. The
@@ -592,7 +593,7 @@
 				self._scc.update_record(['3f00', '7f4d', k], n + ofs, msg)
 
 
-class SuperSim(_MagicSimBase):
+class SuperSim(MagicSimBase):
 
 	name = 'supersim'
 
@@ -605,7 +606,7 @@
 	_ki_file = None
 
 
-class MagicSim(_MagicSimBase):
+class MagicSim(MagicSimBase):
 
 	name = 'magicsim'
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24028
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I315c646d94a1d3282917f5abb0c93efb918b53d7
Gerrit-Change-Number: 24028
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210502/d9635cb7/attachment.htm>


More information about the gerrit-log mailing list