Change in pysim[master]: transport/AT: Make sure PDU has upper case hex digits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Falkenber9 gerrit-no-reply at lists.osmocom.org
Sat May 1 06:13:15 UTC 2021


Falkenber9 has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24023 )


Change subject: transport/AT: Make sure PDU has upper case hex digits
......................................................................

transport/AT: Make sure PDU has upper case hex digits

Some modems may reject AT+CSIM if PDU contains lower
case hex digits [a-f]. Modem response is "ERROR"
without any error code.

This patch converts each PDU to upper case.

Tested with Sierra Wireless EM7565.
Example:
AT+CSIM=14,"00a40004023F00"
ERROR
AT+CSIM=14,"00A40004023F00"
+CSIM: 4,"612F"

OK


Change-Id: I318e36abc7ae975c62d32b7fe0ec949bf5997d13
---
M pySim/transport/modem_atcmd.py
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/24023/1

diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py
index ecf463c..eef38cb 100644
--- a/pySim/transport/modem_atcmd.py
+++ b/pySim/transport/modem_atcmd.py
@@ -99,6 +99,9 @@
 		pass # Nothing to do really ...
 
 	def _send_apdu_raw(self, pdu):
+		# Make sure pdu has upper case hex digits [A-F]
+		pdu = pdu.upper()
+
 		# Prepare the command as described in 8.17
 		cmd = 'AT+CSIM=%d,\"%s\"' % (len(pdu), pdu)
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I318e36abc7ae975c62d32b7fe0ec949bf5997d13
Gerrit-Change-Number: 24023
Gerrit-PatchSet: 1
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210501/a394c94a/attachment.htm>


More information about the gerrit-log mailing list