Change in pysim[master]: commands, ts_102_221: replace pytlv with uttlv

dexter gerrit-no-reply at lists.osmocom.org
Tue Mar 30 14:45:24 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/23483/3/pySim/commands.py 
File pySim/commands.py:

https://gerrit.osmocom.org/c/pysim/+/23483/3/pySim/commands.py@36 
PS3, Line 36: 		from u
> there's at least 5 instances of "... = TLV() tag_size=1, len_size=1" in the code. […]
I have had a look at cyberfle-shell and the card repo from mitshell. mitshell has a BER-TLV parser. I have tried it out with some testcode and it seems to work. uttlv is MIT license (I don't know how compatible that is). Mitshell uses GPL.


https://gerrit.osmocom.org/c/pysim/+/23483/3/pySim/commands.py@36 
PS3, Line 36: 		from u
> I think we should move this to the top of the file. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 30 Mar 2021 14:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210330/f39f6c2d/attachment.htm>


More information about the gerrit-log mailing list