Change in pysim[master]: pySim-shell: automatic ADM pin from CSV-File

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 29 20:43:04 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23538 )

Change subject: pySim-shell: automatic ADM pin from CSV-File
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py@368 
PS1, Line 368: 	csv_
I would go for something like ~/.osmocom/pysim/card_data.csv
* ~/.osmocom is already used by OsmocomBB
* the filename doesn't need to contain 'shell' as this CSV file might actually end up being used by other pysim tools later on, too.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I51835ccb16bcbce35e7f3765e8927a4451509e77
Gerrit-Change-Number: 23538
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 29 Mar 2021 20:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210329/e61f9948/attachment.htm>


More information about the gerrit-log mailing list