This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23536 ) Change subject: fileystem: fix ADF selection ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/23536/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/23536/1/pySim/cards.py@230 PS1, Line 230: if adf in aid: is that a random sub-string match? I think that is dangerous, as it could match at any point, not just from the start. IMHO the only acceptable match is a substring match from the start of the long AID, but not anywhere else within it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If99b143ae5ff42a889c52e8023084692e709e1b1 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 29 Mar 2021 20:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210329/41d6c642/attachment.htm>