Change in pysim[master]: ts_31_102: do not add empty ShellCommands class.

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 29 20:36:57 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23534 )

Change subject: ts_31_102: do not add empty ShellCommands class.
......................................................................


Patch Set 1: Code-Review+1

it is still useful to be able to add application specific commands.  I guess the mistake was to not append those commands but rather overwrite a field that was already specified by the superclass during super.__init__.  I think a working example on how to do application specific commands would be a good idea.  Not sure if we have any real example of how to do that in the code?


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3
Gerrit-Change-Number: 23534
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 29 Mar 2021 20:36:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210329/d18c9acd/attachment.htm>


More information about the gerrit-log mailing list