This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23455 ) Change subject: gprs_ns2_vty: print a response to vty `nsvc <nsvci> (block|unblock|reset) ...................................................................... Patch Set 2: (3 comments) Some cosmetic notes... https://gerrit.osmocom.org/c/libosmocore/+/23455/2/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/23455/2/src/gb/gprs_ns2_vty.c@2061 PS2, Line 2061: %d I find this inconsistent with the existing code: above %05u is used. https://gerrit.osmocom.org/c/libosmocore/+/23455/2/src/gb/gprs_ns2_vty.c@2067 PS2, Line 2067: vty_out(vty, "An unknown error %d happend%s", rc, VTY_NEWLINE); Consistency: missing dot, other statements have it. https://gerrit.osmocom.org/c/libosmocore/+/23455/2/src/gb/gprs_ns2_vty.c@2080 PS2, Line 2080: vty_out(vty, "An unknown error %d happend%s", rc, VTY_NEWLINE); Consistency: missing dot, other statements have it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbb83ea319bbdc94177febdd66e79c49fce7fdd2 Gerrit-Change-Number: 23455 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 28 Mar 2021 13:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210328/b5051609/attachment.htm>