Change in pysim[master]: commands, ts_102_221: replace pytlv with uttlv

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 27 18:31:35 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23483/3/pySim/commands.py 
File pySim/commands.py:

https://gerrit.osmocom.org/c/pysim/+/23483/3/pySim/commands.py@36 
PS3, Line 36: 		from u
I think we should move this to the top of the file. pySim will require uttlv installed anyway for various parts of the code, so there's no point in movign the import/from statement into a specific method.  That only makes sense if most of the functionality / use cases work without uttlv, and hence the dependency is optional.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 27 Mar 2021 18:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210327/7bc826fa/attachment.htm>


More information about the gerrit-log mailing list