Change in pysim[master]: pySim-shell: add ADF.ISIM / ADF.USIM dynamically

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 27 18:19:59 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23473 )

Change subject: pySim-shell: add ADF.ISIM / ADF.USIM dynamically
......................................................................


Patch Set 3: Code-Review+2

(3 comments)

merging this as-is to avoid further delays.  However, the "error:" that is no error should probably be adressed in a follow-up patch.

https://gerrit.osmocom.org/c/pysim/+/23473/3/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23473/3/pySim-shell.py@255 
PS3, Line 255: 	profile.add_application(ADF_USIM())
this should probably be done automagically, but I can look at this separately in a follow-up patch.


https://gerrit.osmocom.org/c/pysim/+/23473/3/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/23473/3/pySim/filesystem.py@566 
PS3, Line 566:    
not sure if we should directly print here, instaed of going through either cmd2 or logging.  But can be modified later as needed.


https://gerrit.osmocom.org/c/pysim/+/23473/3/pySim/filesystem.py@577 
PS3, Line 577:    
I guess we'd rather want to raise some kind of exception here, if this is an error?  IMHO it is actually not an error, but simply shows that we're dealing with a non-UICC card (i.e. a classic SIM without EF.DIR)?



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23473
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I42ee23375f98e6322708c1c4db6d65e1425feecd
Gerrit-Change-Number: 23473
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Mar 2021 18:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210327/9c08cc0a/attachment.htm>


More information about the gerrit-log mailing list