This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23501 ) Change subject: pySim-shell: fix verify_chv command ...................................................................... pySim-shell: fix verify_chv command The verify_chv command passes the code directly to _scc.verify_chv(), but this method accepts bytes not an ascii string. Like with verfy_adm we need to run the code through sanitize_pin_adm() and h2b() first. Change-Id: I3a003fc57bcf6c4f0a1ea8142e08b3183e655fad Related: OS#4963 --- M pySim-shell.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/01/23501/1 diff --git a/pySim-shell.py b/pySim-shell.py index 946b3e5..078a5d3 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -109,7 +109,8 @@ @cmd2.with_argparser(verify_chv_parser) def do_verify_chv(self, opts): """Verify (authenticate) using specified CHV (PIN)""" - (data, sw) = self._cmd.card._scc.verify_chv(opts.chv_nr, opts.code) + chv = sanitize_pin_adm(opts.code) + (data, sw) = self._cmd.card._scc.verify_chv(opts.chv_nr, h2b(chv)) self._cmd.poutput(data) dir_parser = argparse.ArgumentParser() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3a003fc57bcf6c4f0a1ea8142e08b3183e655fad Gerrit-Change-Number: 23501 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/2642d627/attachment.htm>