Change in osmo-sgsn[master]: mm_iu: Expect E_PMM_PS_ATTACH when in ST_PMM_IDLE

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 25 16:57:52 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23500 )


Change subject: mm_iu: Expect E_PMM_PS_ATTACH when in ST_PMM_IDLE
......................................................................

mm_iu: Expect E_PMM_PS_ATTACH when in ST_PMM_IDLE

It can happen that the MS tries to attach while SGSN's MM Iu state is
ST_PMM_IDLE (eg because UE was hard rebooted). Since Attach is a
specific case of getting a Connection Established, also allow it as a
trigger to transit to state ST_PMM_CONNECTED.

Related: SYS#5389
Change-Id: Ia74a062ddc3052faad569f1428f0ddd02e5b188d
---
M src/sgsn/gprs_mm_state_iu_fsm.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/00/23500/1

diff --git a/src/sgsn/gprs_mm_state_iu_fsm.c b/src/sgsn/gprs_mm_state_iu_fsm.c
index e571026..69b4ef0 100644
--- a/src/sgsn/gprs_mm_state_iu_fsm.c
+++ b/src/sgsn/gprs_mm_state_iu_fsm.c
@@ -81,6 +81,7 @@
 static void st_pmm_idle(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
 	switch(event) {
+	case E_PMM_PS_ATTACH:
 	case E_PMM_PS_CONN_ESTABLISH:
 		mm_state_iu_fsm_state_chg(fi, ST_PMM_CONNECTED);
 		break;
@@ -117,7 +118,10 @@
 		.action = st_pmm_connected,
 	},
 	[ST_PMM_IDLE] = {
-		.in_event_mask = X(E_PMM_IMPLICIT_DETACH) | X(E_PMM_PS_CONN_ESTABLISH),
+		.in_event_mask =
+			X(E_PMM_IMPLICIT_DETACH) |
+			X(E_PMM_PS_CONN_ESTABLISH) |
+			X(E_PMM_PS_ATTACH),
 		.out_state_mask = X(ST_PMM_DETACHED) | X(ST_PMM_CONNECTED),
 		.name = "Idle",
 		.onenter = st_pmm_idle_on_enter,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23500
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia74a062ddc3052faad569f1428f0ddd02e5b188d
Gerrit-Change-Number: 23500
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/decb81f9/attachment.htm>


More information about the gerrit-log mailing list