Change in osmo-bts[master]: sched_lchan_tchh: fix frame number and fill FACCH gap

dexter gerrit-no-reply at lists.osmocom.org
Thu Mar 25 16:27:46 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21329 )

Change subject: sched_lchan_tchh: fix frame number and fill FACCH gap
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 3:
> 
> trying to unblock this: Do we have a test case for this that can show the problem is fixed by this patch? dexter? If so, then I think we should merge the patch as-is, asap.

Yes, there is a TTCN3 testcase that triggers the problem: TC_meas_res_speech_tchh_facch should pass after the patch is merged.

https://gerrit.osmocom.org/c/osmo-bts/+/21329/2/src/osmo-bts-trx/sched_lchan_tchh.c 
File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21329/2/src/osmo-bts-trx/sched_lchan_tchh.c@71 
PS2, Line 71: 	unsigned int fn_tch_end;	
> ws
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9fa3815feb2b4da608ab7df716a87ba1f2f91
Gerrit-Change-Number: 21329
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 25 Mar 2021 16:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/0eac3d2b/attachment.htm>


More information about the gerrit-log mailing list