Change in osmo-gsm-manuals[master]: common/chapters: extend gb/ns2 chapters

daniel gerrit-no-reply at lists.osmocom.org
Thu Mar 25 12:55:35 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393 )

Change subject: common/chapters: extend gb/ns2 chapters
......................................................................


Patch Set 3:

(18 comments)

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc 
File common/chapters/gb-ns2-configuration.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@18 
PS3, Line 18: hdlcnet1
Change all hdlcnetx device names to hdlcx which is the default device name (even if you operate your card in frnet).

hdlcx/hdlcnetx is only created for the virtual loopback device pairs


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@29 
PS3, Line 29: sidea1
s/sidex/sitex/ ?
Not sure if you actually meant side, site makes more sense to me, maybe even bss<x><n>?


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@70 
PS3, Line 70: In difference the dynamic configuration allows the SGSN to have only a reduced configuration.
In contrast?


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@141 
PS3, Line 141: <2> bind to 10.100.0.1
:23000


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@142 
PS3, Line 142: <3> NSE 1001 with 2 NSVC
"add NSE 1001..."


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@145 
PS3, Line 145:  BSS
as BSS


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@147 
PS3, Line 147:  do
remove do


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2-configuration.adoc@168 
PS3, Line 168: <2> bind to 10.100.0.1
:23000


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/2/common/chapters/gb-ns2.adoc 
File common/chapters/gb-ns2.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/2/common/chapters/gb-ns2.adoc@54 
PS2, Line 54: The Osmocom NS/FR support currently requires the individual Frame Relay
> s/support/implementation/ ?
ACK


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc 
File common/chapters/gb-ns2.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@42 
PS3, Line 42: a
an


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@42 
PS3, Line 42: a
an


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@79 
PS3, Line 79: NOTE: GRE/IP has been removed from Osmocom NS code.
Do we want to be so blunt or rather mention that GRE has not been reimplemented so far?


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@105 
PS3, Line 105: This is the only official, 3GPP-standardized way of speaking a Gb
"...speaking a Gb interface" sounds strange
"speaking Gb over IP-based transports"?


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@113 
PS3, Line 113: ===== Gb over IP 3GPP auto-configuration
Should this heading be here? The differences mentioned below apply to static as well as dynamic configuration, don't they?


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@115 
PS3, Line 115: allow
allows


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@121 
PS3, Line 121: IP based Gb
"IP-based Gb protocol" (in ns2 we call it dialect, so maybe that?)


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@143 
PS3, Line 143: a
an


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/3/common/chapters/gb-ns2.adoc@171 
PS3, Line 171: persistant
s/persistant/persistent/, also twice below



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I902b850528cbc04bd469590babd84cccf64300e8
Gerrit-Change-Number: 23393
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Mar 2021 12:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/12760e83/attachment.htm>


More information about the gerrit-log mailing list