Change in osmo-pcu[master]: Track scheduled UL blocks through USF

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 25 12:19:36 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23492 )

Change subject: Track scheduled UL blocks through USF
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/pdch.cpp@924 
PS1, Line 924: 		case PDCH_ULC_NODE_TBF_POLL:
> Shouldn't you compare for tbf != node->tbf_poll. […]
We don't expect an answer to a POLL here at all, since we are receiving a DATA block. Polling (RRBP) always involve the MS answering with a CTRL message (be it DL ACK/NACK, or CTRL ACK, etc.).

So it's fine printing a warning here regardless of the TBF. We expected a CTRL message here but we received a data one.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23492
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia99c9edad6e5bd837e9baeb4fb2683b227887957
Gerrit-Change-Number: 23492
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 25 Mar 2021 12:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/131e4d9e/attachment.htm>


More information about the gerrit-log mailing list