Change in osmo-pcu[master]: Track scheduled UL blocks through USF

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 25 11:43:34 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23492 )

Change subject: Track scheduled UL blocks through USF
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/gprs_rlcmac_sched.cpp@463 
PS1, Line 463: 	poll_fn = rts_next_fn(fn, block_nr);
> > So that means that whenever we request USF on FN = x, the PCU expects the response on FN = x + 1. […]
Yes, I meant x+4 actually, or x+1 as in full blocks. Ok I get it now, I was indeed not thinking about the fact that each block is actually 4 frames (or 5 sometimes?) and hence of course the MS cannot answer until it fully received it, hence why the 4-5 FN offset.
So that means the implementation is correct here, only my assumptions were confusing. Thanks for the explanation!



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23492
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia99c9edad6e5bd837e9baeb4fb2683b227887957
Gerrit-Change-Number: 23492
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 25 Mar 2021 11:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/c865da92/attachment.htm>


More information about the gerrit-log mailing list