Change in pysim[master]: commands, ts_102_221: replace pytlv with uttlv

daniel gerrit-no-reply at lists.osmocom.org
Wed Mar 24 16:35:03 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 1:

The API of uttlv looks much nicer (using bytes/ints and not hex-coded strings for the tags)

Could you also change the *_TLV_MAP dicts to index with an int instead of a string?
Then you wouldn't need to generate atempl_str/fcp_str/prop_str

(note: I didn't really look much into it, so I'm not sure if this makes sense)


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 24 Mar 2021 16:35:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/802e3866/attachment.htm>


More information about the gerrit-log mailing list