Change in libosmocore[master]: gprs_ns2_vty: print a response to vty `nsvc <nsvci> (block|unblock|re...

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Mar 24 15:46:36 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23455 )

Change subject: gprs_ns2_vty: print a response to vty `nsvc <nsvci> (block|unblock|reset)
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/23455/1/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/23455/1/src/gb/gprs_ns2_vty.c@1918 
PS1, Line 1918: 			vty_out(vty, "An unknown error happend%s", VTY_NEWLINE);
> might make sens to %d the 'rc' in this caese, rather than "unknown"?
Done


https://gerrit.osmocom.org/c/libosmocore/+/23455/1/src/gb/gprs_ns2_vty.c@1936 
PS1, Line 1936: 		vty_out(vty, "The NS-VC %d has been resetted.%s", id, VTY_NEWLINE);
> is resetted correct? or simply reset?
the internet doesn't have a binary answer to this.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23455
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbb83ea319bbdc94177febdd66e79c49fce7fdd2
Gerrit-Change-Number: 23455
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 24 Mar 2021 15:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/4e7667b2/attachment.htm>


More information about the gerrit-log mailing list