Change in libosmocore[master]: gprs_ns2: always use the same method to print NSVCs

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 24 15:30:44 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23450 )

Change subject: gprs_ns2: always use the same method to print NSVCs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23450/1/tests/gb/gprs_ns2_vty.vty 
File tests/gb/gprs_ns2_vty.vty:

https://gerrit.osmocom.org/c/libosmocore/+/23450/1/tests/gb/gprs_ns2_vty.vty@46 
PS1, Line 46:  NSVCI none: RECOVERING PERSIST data_weight=1 sig_weight=1 udp)[127.0.0.14]:42999<>[127.0.0.15]:9496
the indent level is wrong here.  The "1 NS-VC" is already indented two spaces, and the NSVCIs below should have at least 3 or 4 spaces indent



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23450
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If31ec6c1c07dc134ab1ddeb915bc89747c7be048
Gerrit-Change-Number: 23450
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Mar 2021 15:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/239d40c3/attachment.htm>


More information about the gerrit-log mailing list