This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23481 ) Change subject: gprs_ns2_sns: Don't create NS-VCs for binds outside the NSE ...................................................................... gprs_ns2_sns: Don't create NS-VCs for binds outside the NSE We may very well have any number of binds configured, but which are not part of the current NSE. When creating the "full mesh" of NS-VCs after SNS-CONFIG, we must only iterate over those binds that are part of the NSE (or 'ipa-sns-default bind' in cae of SGSN role), but not over all the other binds that may exist in the system. Closes: OS#5092 Change-Id: Ida361fa02ad1d86844d54c8f0664c996ed28e30a --- M src/gb/gprs_ns2_sns.c 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/23481/1 diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index 5470e43..00a6520 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -387,7 +387,7 @@ struct ns2_sns_state *gss = (struct ns2_sns_state *) fi->priv; struct gprs_ns2_nse *nse = nse_inst_from_fi(fi); struct gprs_ns2_vc *nsvc; - struct gprs_ns2_vc_bind *bind; + struct ns2_sns_bind *sbind; struct osmo_sockaddr remote = { }; unsigned int i; @@ -399,8 +399,9 @@ remote.u.sin.sin_addr.s_addr = ip4->ip_addr; remote.u.sin.sin_port = ip4->udp_port; - /* iterate over all local binds */ - llist_for_each_entry(bind, &nse->nsi->binding, list) { + /* iterate over all local binds within this SNS */ + llist_for_each_entry(sbind, &gss->binds, list) { + struct gprs_ns2_vc_bind *bind = sbind->bind; bool found; /* we only care about UDP binds */ @@ -431,8 +432,9 @@ remote.u.sin6.sin6_addr = ip6->ip_addr; remote.u.sin6.sin6_port = ip6->udp_port; - /* iterate over all local binds */ - llist_for_each_entry(bind, &nse->nsi->binding, list) { + /* iterate over all local binds within this SNS */ + llist_for_each_entry(sbind, &gss->binds, list) { + struct gprs_ns2_vc_bind *bind = sbind->bind; bool found; if (bind->ll != GPRS_NS2_LL_UDP) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida361fa02ad1d86844d54c8f0664c996ed28e30a Gerrit-Change-Number: 23481 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/1c389ff0/attachment.htm>