Change in libosmocore[master]: gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 23 23:53:30 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23411 )

Change subject: gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC
......................................................................

gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC

It is the SGSN's job to ensure sufficient NS-VC capacity.  As the SGSN
doesn't tell the BSS, we should not make assumptions of only 4.

Change-Id: I41f493643cf51d7853959ab9c7bbc0ffae4e1f4b
---
M src/gb/gprs_ns2_sns.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index ec48eda..1af9631 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -812,7 +812,6 @@
 		}
 
 		gss->num_ip4_local = count;
-		gss->num_max_ip4_remote = 4;
 		gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip4_remote * gss->num_ip4_local, 8);
 		break;
 	case IPv6:
@@ -849,7 +848,6 @@
 			ip6_elems++;
 		}
 		gss->num_ip6_local = count;
-		gss->num_max_ip6_remote = 4;
 		gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip6_remote * gss->num_ip6_local, 8);
 		break;
 	}
@@ -1560,6 +1558,9 @@
 	fi->priv = gss;
 	gss->nse = nse;
 	gss->role = GPRS_SNS_ROLE_BSS;
+	/* The SGSN doesn't tell the BSS, so we assume there's always sufficient */
+	gss->num_max_ip4_remote = 8192;
+	gss->num_max_ip6_remote = 8192;
 	INIT_LLIST_HEAD(&gss->sns_endpoints);
 	INIT_LLIST_HEAD(&gss->binds);
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I41f493643cf51d7853959ab9c7bbc0ffae4e1f4b
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/0b1f61a3/attachment.htm>


More information about the gerrit-log mailing list