Change in libosmocore[master]: gprs_ns2_vty: Allow creating NSE in sgsn-role

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 23 19:53:50 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23408 )

Change subject: gprs_ns2_vty: Allow creating NSE in sgsn-role
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23408/4/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/23408/4/src/gb/gprs_ns2_vty.c@273 
PS4, Line 273:       "nse <0-65535> [sgsn-role]",
conclusion from a joint call with lynxis and dwillmann is that we at the very least want to rename this to ip-sns-role-sgsn and then also verify that users cannot add an "initial remote endpoint" in that case.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I694fa6c80d04d13cb1afaae93a9ae43b6dfd2207
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Mar 2021 19:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/feab9acb/attachment.htm>


More information about the gerrit-log mailing list