Change in pysim[master]: pySim-shell: add ADF.ISIM / ADF.USIM dynamically

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 23 17:54:28 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23473 )

Change subject: pySim-shell: add ADF.ISIM / ADF.USIM dynamically
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/23473/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23473/1/pySim-shell.py@a259 
PS1, Line 259: 	#
the fixme probably still applies to DF_TELECOM and DF_GSM, where it's currently unclear how to do that better.


https://gerrit.osmocom.org/c/pysim/+/23473/1/pySim-shell.py@266 
PS1, Line 266: 			if "a0000000871002" in a:
I would move this entire new block into a function / method, rather than only having it in 'main'.  This way it can be used in the future from possibly other parts of the code.

Also, please avoid hard-coding some specific AIDs here.  The CardApplication classes should themselves "know" their AID and register somewhere with common infrastructure (either by explicit code or by some kind of syntactic sugar).

This loop then should iterate over the AIDs in the EF_DIR and try to find an application registered for the AID.

This way we can always easily add support for new applications by simply creating another [instance of] a derived class of CardApplication, and not have to change some kind of hard-coded duplicated aid list in this iterator function.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23473
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I42ee23375f98e6322708c1c4db6d65e1425feecd
Gerrit-Change-Number: 23473
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 23 Mar 2021 17:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/be952b54/attachment.htm>


More information about the gerrit-log mailing list