Change in libosmocore[master]: gprs_ns2: Add comments explaining the nsvc->sns_only field

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Mar 23 14:15:06 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23416 )

Change subject: gprs_ns2: Add comments explaining the nsvc->sns_only field
......................................................................


Patch Set 3: Code-Review+2

> Patch Set 3:
> 
> > Patch Set 3:
> > 
> > sns_only is a NS-VC which is only used as initial endpoint to configure it.
> > E.g. SNS auto-configuration
> > 
> > BSS connects to SGSN/10.0.0.1
> > BSS -> SGSN SIZE
> > [..]
> > BSS <- SGSN SNS-Config my endpoints are 10.1.1.1, 10.2.2.2
> > 
> > So 10.0.0.1 is not annouced by the SGSN as endpoint and must be removed after the SNS process succeeds. For this reason the NS-VC has sns_only = true.
> 
> how does this differ from the comments I put in the code?  I don't see the difference or the disagreement?

I misunderstood your "?" in the comment. I thought you wasn't sure if this is true. Just re-read it in a different context. Sorry. everything is good.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I16009a1b03d8027de2be56b7d5013b755c9550fd
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Mar 2021 14:15:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/aaa7cf60/attachment.htm>


More information about the gerrit-log mailing list