Change in libosmocore[master]: gprs_ns2_sns: Allow VTY configuration of default binds for IP-SNS

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 23 14:11:46 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23415 )

Change subject: gprs_ns2_sns: Allow VTY configuration of default binds for IP-SNS
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/23415/3/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/23415/3/src/gb/gprs_ns2_vty.c@566 
PS3, Line 566: 	llist_for_each_entry(vbind, &ip_sns_default_binds, list) {
> I'm not sure if we want to have default binds for individual nses? […]
how would that work?


https://gerrit.osmocom.org/c/libosmocore/+/23415/3/src/gb/gprs_ns2_vty.c@599 
PS3, Line 599: 
> Should the writing of default binds be here?
sure, it could be moved.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id01c29b07e9203c9305f2129361a4f5aaefa2c52
Gerrit-Change-Number: 23415
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Mar 2021 14:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/e588c42f/attachment.htm>


More information about the gerrit-log mailing list