Change in libosmocore[master]: gprs_ns2_vty: Allow creating NSE in sgsn-role

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Mar 23 13:59:35 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23408 )

Change subject: gprs_ns2_vty: Allow creating NSE in sgsn-role
......................................................................


Patch Set 3:

I would not like to have the "[sgsn-role]" in the vty-NSE line "nse <0-65535> [sgsn-role]".
The SGSN role is only used for sns. To be consistant with the other NSE configuration I would like to configure it a level down.

... or add a complete type to the top for all NSE but this might break the current vty.
How about (just starting to test things out)

nse <0-65535>
 ip-sns-configuration (which forbids the endpoint)
or
 ip-sns-role sgsn (which forbids the endpoint)
 ip-sns-bind some_udp1 (is this optional or required)?
 ip-sns-bind some_udp2


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I694fa6c80d04d13cb1afaae93a9ae43b6dfd2207
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Mar 2021 13:59:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/6a5cc7b7/attachment.htm>


More information about the gerrit-log mailing list