This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23406 ) Change subject: gprs_ns2_sns: Add some more OSMO_ASSERT about BSS role ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/23406/3/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/23406/3/src/gb/gprs_ns2_sns.c@714 PS3, Line 714: static void ns2_sns_st_unconfigured(struct osmo_fsm_inst *fi, uint32_t event, void *data) Since we now have ns2_sns_st_sgsn_unconfigured rename this to ns2_sns_st_bss_unconfigured? https://gerrit.osmocom.org/c/libosmocore/+/23406/3/src/gb/gprs_ns2_sns.c@1013 PS3, Line 1013: OSMO_ASSERT(gss->role == GPRS_SNS_ROLE_BSS); The naming is quite confusing now - config_sgsn_onenter with OSMO_ASSERT(ROLE_BSS) Rename the BSS-States GPRS_SNS_ST_BSS_CONFIG_BSS and GPRS_SNS_ST_BSS_CONFIG_SGSN? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I20d1bd8df62e0bb84696e291756e2d96acf49246 Gerrit-Change-Number: 23406 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 23 Mar 2021 12:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/89d161e0/attachment.htm>