Change in pysim[master]: commands: better exception string for authentication failures

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 23 11:52:38 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23423 )

Change subject: commands: better exception string for authentication failures
......................................................................


Patch Set 1: Code-Review+1

> Patch Set 1:

> I have now analyzed the problem a bit. What we could do is to use rs.interpret_sw() from do_verify_adm() to convert the SW, but then still the translation would be wrong. The reason for this is that the 63cx SW has a different meaning when it is used when the VERIFY PIN command is used. See ETSI TS 102 221, Table 10.9.

Nice catch, and sory for misleading you in the first place.  So it seems indeed we need to take this approach, unless we want card profiles to be able to register INS-specific SW parsers :(


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icf428831094f8c1045eefaa8cb2b92e6a36b0c13
Gerrit-Change-Number: 23423
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 23 Mar 2021 11:52:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210323/778d8839/attachment.htm>


More information about the gerrit-log mailing list