Change in osmo-pcu[master]: pdch_ul_controller: Fix compiler warning on gcc-10.2

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 22 09:40:54 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23427 )

Change subject: pdch_ul_controller: Fix compiler warning on gcc-10.2
......................................................................

pdch_ul_controller: Fix compiler warning on gcc-10.2

pdch_ul_controller.c: In function ‘pdch_ulc_release_tbf’:
pdch_ul_controller.c:217:7: error: ‘item_tbf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  217 |    if (item_tbf != tbf)
      |       ^

Change-Id: I42120fdf23753945ebc16bb5469d9fd253c3da37
---
M src/pdch_ul_controller.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c
index 173fd8f..cd705d0 100644
--- a/src/pdch_ul_controller.c
+++ b/src/pdch_ul_controller.c
@@ -213,6 +213,8 @@
 			case PDCH_ULC_NODE_TBF_USF:
 				item_tbf = (struct gprs_rlcmac_tbf *)item->tbf_usf.ul_tbf;
 				break;
+			default:
+				OSMO_ASSERT(0);
 			}
 			if (item_tbf != tbf)
 				continue;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23427
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42120fdf23753945ebc16bb5469d9fd253c3da37
Gerrit-Change-Number: 23427
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210322/4cfd8bdd/attachment.htm>


More information about the gerrit-log mailing list