Change in osmo-pcu[master]: gprs_bssgp_pcu: ensure only known BVCI can be resetted by the SGSN

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Mar 20 16:51:23 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23014 )

Change subject: gprs_bssgp_pcu: ensure only known BVCI can be resetted by the SGSN
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c 
File src/gprs_bssgp_pcu.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c@460 
PS4, Line 460: !TLVP_PRESENT(&tp, BSSGP_IE_BVCI)
> I agree, we should add it in another commit. […]
mark this as resolved.


https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c@461 
PS4, Line 461: an
> It's also called BVC-RESET, not BSSGP-RESET
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I04e36ce4a29e51d85e67a0d3a81aa0e1eb9e9c08
Gerrit-Change-Number: 23014
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 20 Mar 2021 16:51:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210320/5802bf0c/attachment.htm>


More information about the gerrit-log mailing list