Change in osmo-ttcn3-hacks[master]: sgsn: Avoid race condition in TC_suspend_rau()

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 20 15:26:30 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23425 )

Change subject: sgsn: Avoid race condition in TC_suspend_rau()
......................................................................

sgsn: Avoid race condition in TC_suspend_rau()

In f_routing_area_update() we are sending a RAU Complete to the SGSN
and then immediately afterwards send a GTP-U from the simulated
GGSN to the SGSN.  That GTP might reach the SGSN faster than the
RAU Complete, resulting in a test failure.

Change-Id: Ic489e0857115cf24965e413a39918edc5a8f44f8
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 79e7434..6c8ea61 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -3105,6 +3105,9 @@
 	/* perform RAU (implicit RESUME) */
 	f_routing_area_update(g_pars.ra);
 
+	/* give SGSN some time to actually receve + process the RAU Complete we sent */
+	f_sleep(0.5);
+
 	/* now data should be flowing again */
 	f_gtpu_xceive_mt(apars, f_rnd_octstring(100));
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23425
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic489e0857115cf24965e413a39918edc5a8f44f8
Gerrit-Change-Number: 23425
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210320/a9bb40c1/attachment.htm>


More information about the gerrit-log mailing list