Change in pysim[master]: filesystem: add comment to inform about checks in add_file()

dexter gerrit-no-reply at lists.osmocom.org
Fri Mar 19 17:01:18 UTC 2021


dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23377 )

Change subject: filesystem: add comment to inform about checks in add_file()
......................................................................

filesystem: add comment to inform about checks in add_file()

The method add_file of class CardDF does some constraint checking
to the basic file parameters (e.g. fid). Since one might also expect
those checks in the superclass CardFile lets leave a comment to make
the code better understandable.

Change-Id: Iebae28909fe6aade3bd4024112a222819572d735
Related: OS#4963
---
M pySim/filesystem.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index 4c84f66..f412d73 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -55,6 +55,10 @@
             self.parent.add_file(self)
         self.shell_commands = []
 
+	# Note: the basic properties (fid, name, ect.) are verified when
+	# the file is attached to a parent file. See method add_file() in
+	# class Card DF
+
     def __str__(self):
         if self.name:
             return self.name

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23377
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iebae28909fe6aade3bd4024112a222819572d735
Gerrit-Change-Number: 23377
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/74afd967/attachment.htm>


More information about the gerrit-log mailing list