Change in pysim[master]: filesystem: be more strict in method add_file()

dexter gerrit-no-reply at lists.osmocom.org
Fri Mar 19 14:56:52 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23378 )

Change subject: filesystem: be more strict in method add_file()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23378/1/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/23378/1/pySim/filesystem.py@152 
PS1, Line 152:         if child.name[0:3] != "DF." and child.name[0:3] != "EF." and child.name[0:4] != "ADF.":
> I wouldn't enforce this name prefix.  I think it's more a convention than "law". […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23378
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I096907285b742e611d221b03ba067ea2522e7e52
Gerrit-Change-Number: 23378
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 19 Mar 2021 14:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/48752e2c/attachment.htm>


More information about the gerrit-log mailing list