Change in osmo-pcu[master]: direct_phy: Fix condition dropping rx DATA.ind payload in in

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 19 07:20:16 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23400 )

Change subject: direct_phy: Fix condition dropping rx DATA.ind payload in in
......................................................................

direct_phy: Fix condition dropping rx DATA.ind payload in in

Related: OS#5020
Fixes: 81c549d5be1f5e161d6231d3f2e5fb4aa3b0557c
Change-Id: Iad8e50b856009439d78c596c5b54dc3e9836e1d4
---
M src/osmo-bts-litecell15/lc15_l1_if.c
M src/osmo-bts-oc2g/oc2g_l1_if.c
M src/osmo-bts-sysmo/sysmo_l1_if.c
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-litecell15/lc15_l1_if.c b/src/osmo-bts-litecell15/lc15_l1_if.c
index 99c82a1..13e0fc9 100644
--- a/src/osmo-bts-litecell15/lc15_l1_if.c
+++ b/src/osmo-bts-litecell15/lc15_l1_if.c
@@ -217,7 +217,7 @@
 	case GsmL1_Sapi_Pacch:
 		/* PDTCH / PACCH frame handling */
 		if (data_ind->msgUnitParam.u8Size != 0 &&
-		    data_ind->msgUnitParam.u8Buffer[0] != GsmL1_PdtchPlType_Full) {
+		    data_ind->msgUnitParam.u8Buffer[0] == GsmL1_PdtchPlType_Full) {
 			data = data_ind->msgUnitParam.u8Buffer + 1;
 			data_len = data_ind->msgUnitParam.u8Size - 1;
 			if (data_len == 0)
diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c
index 101bd56..a41e7af 100644
--- a/src/osmo-bts-oc2g/oc2g_l1_if.c
+++ b/src/osmo-bts-oc2g/oc2g_l1_if.c
@@ -222,7 +222,7 @@
 	case GsmL1_Sapi_Pacch:
 		/* PDTCH / PACCH frame handling */
 		if (data_ind->msgUnitParam.u8Size != 0 &&
-		    data_ind->msgUnitParam.u8Buffer[0] != GsmL1_PdtchPlType_Full) {
+		    data_ind->msgUnitParam.u8Buffer[0] == GsmL1_PdtchPlType_Full) {
 			data = data_ind->msgUnitParam.u8Buffer + 1;
 			data_len = data_ind->msgUnitParam.u8Size - 1;
 			if (data_len == 0)
diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c
index 29656d7..225f732 100644
--- a/src/osmo-bts-sysmo/sysmo_l1_if.c
+++ b/src/osmo-bts-sysmo/sysmo_l1_if.c
@@ -201,7 +201,7 @@
 	case GsmL1_Sapi_Pacch:
 		/* PDTCH / PACCH frame handling */
 		if (data_ind->msgUnitParam.u8Size != 0 &&
-		    data_ind->msgUnitParam.u8Buffer[0] != GsmL1_PdtchPlType_Full) {
+		    data_ind->msgUnitParam.u8Buffer[0] == GsmL1_PdtchPlType_Full) {
 			data = data_ind->msgUnitParam.u8Buffer + 1;
 			data_len = data_ind->msgUnitParam.u8Size - 1;
 			if (data_len == 0)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iad8e50b856009439d78c596c5b54dc3e9836e1d4
Gerrit-Change-Number: 23400
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/ff351a4d/attachment.htm>


More information about the gerrit-log mailing list