Change in osmo-pcu[master]: sysmo: fix wrong FN jumps in rx RA.ind

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 19 07:20:16 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23388 )

Change subject: sysmo: fix wrong FN jumps in rx RA.ind
......................................................................

sysmo: fix wrong FN jumps in rx RA.ind

There's no need for setting the FN in RA.ind since we anyway already
receive a DATA.ind beforehand.
Furthermore, the applied delay of 5 in the call is not really used at
all.

Change-Id: I437f4f95d054aea96bec3b9343e495451020ff3c
---
M src/bts.cpp
M src/bts.h
M src/osmo-bts-sysmo/sysmo_l1_if.c
M src/pcu_l1_if.cpp
M src/pcu_l1_if.h
M tests/tbf/TbfTest.cpp
6 files changed, 4 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/bts.cpp b/src/bts.cpp
index c1cee17..dc4159c 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -305,7 +305,7 @@
 	return (fn + GSM_MAX_FN * 3 / 2 - to) % GSM_MAX_FN - GSM_MAX_FN/2;
 }
 
-void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int fn, unsigned max_delay)
+void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int fn)
 {
 	int delay = 0;
 	const int late_block_delay_thresh = 13;
diff --git a/src/bts.h b/src/bts.h
index 9336c89..ab8a973 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -276,7 +276,7 @@
 void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, bool poll, uint16_t pgroup);
 
 void bts_set_current_frame_number(struct gprs_rlcmac_bts *bts, uint32_t frame_number);
-void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int frame_number, unsigned max_delay);
+void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int frame_number);
 static inline uint32_t bts_current_frame_number(const struct gprs_rlcmac_bts *bts)
 {
 	return bts->cur_fn;
diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c
index eb869e1..29656d7 100644
--- a/src/osmo-bts-sysmo/sysmo_l1_if.c
+++ b/src/osmo-bts-sysmo/sysmo_l1_if.c
@@ -240,8 +240,6 @@
 	struct gprs_rlcmac_bts *bts;
 	bts = llist_first_entry_or_null(&the_pcu->bts_list, struct gprs_rlcmac_bts, list);
 
-	pcu_rx_ra_time(bts, ra_ind->u16Arfcn, ra_ind->u32Fn, ra_ind->u8Tn);
-
 	if (ra_ind->measParam.fLinkQuality < MIN_QUAL_RACH)
 		return 0;
 
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index f28c46f..0ccf642 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -273,13 +273,7 @@
 
 void pcu_rx_block_time(struct gprs_rlcmac_bts *bts, uint16_t arfcn, uint32_t fn, uint8_t ts_no)
 {
-	bts_set_current_block_frame_number(bts, fn, 0);
-}
-
-void pcu_rx_ra_time(struct gprs_rlcmac_bts *bts, uint16_t arfcn, uint32_t fn, uint8_t ts_no)
-{
-	/* access bursts may arrive some bursts earlier */
-	bts_set_current_block_frame_number(bts, fn, 5);
+	bts_set_current_block_frame_number(bts, fn);
 }
 
 int pcu_rx_data_ind_pdtch(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_pdch *pdch, uint8_t *data,
diff --git a/src/pcu_l1_if.h b/src/pcu_l1_if.h
index aff23f5..246444c 100644
--- a/src/pcu_l1_if.h
+++ b/src/pcu_l1_if.h
@@ -177,7 +177,6 @@
 	uint8_t len, uint32_t fn, struct pcu_l1_meas *meas);
 
 void pcu_rx_block_time(struct gprs_rlcmac_bts *bts, uint16_t arfcn, uint32_t fn, uint8_t ts_no);
-void pcu_rx_ra_time(struct gprs_rlcmac_bts *bts, uint16_t arfcn, uint32_t fn, uint8_t ts_no);
 uint16_t imsi2paging_group(const char* imsi);
 #ifdef __cplusplus
 }
diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp
index 2986132..46667b4 100644
--- a/tests/tbf/TbfTest.cpp
+++ b/tests/tbf/TbfTest.cpp
@@ -627,7 +627,7 @@
 static void send_ul_mac_block_buf(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_pdch *pdch,
 				  unsigned fn, uint8_t *buf, int num_bytes)
 {
-	bts_set_current_block_frame_number(bts, fn, 0);
+	bts_set_current_block_frame_number(bts, fn);
 	pdch->rcv_block(buf, num_bytes, fn, &meas);
 	pdch_ulc_expire_fn(pdch->ulc, fn);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23388
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I437f4f95d054aea96bec3b9343e495451020ff3c
Gerrit-Change-Number: 23388
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/981f6654/attachment.htm>


More information about the gerrit-log mailing list