Change in pysim[master]: pySim-shell: add basic filesystem check

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 19 07:15:42 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23403 )

Change subject: pySim-shell: add basic filesystem check
......................................................................


Patch Set 1:

I like the idea, but I think we have to be careful to not raise wrong expectations. "check" can mean many things, e.g. in the context of a "filesystem check" like fsck, which it is not.  It also doesn't check conformance with the 3GPP/ETSI specs or anything of that sort.

Hence I'd like to ask you to rename it to something with a clear name, like check-selectable


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9248e2fc067f822d9c4ccc4e48d378eea9ce3354
Gerrit-Change-Number: 23403
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 19 Mar 2021 07:15:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/a10c7f7e/attachment.htm>


More information about the gerrit-log mailing list