Change in pysim[master]: pySim-shell: add filesystem exporter

dexter gerrit-no-reply at lists.osmocom.org
Thu Mar 18 22:03:51 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23210 )

Change subject: pySim-shell: add filesystem exporter
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23210/4/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23210/4/pySim-shell.py@178 
PS4, Line 178: 			self._c
> should we really just ignore erros in reading files? I think we need to check _why_ reading/selectin […]
The errors are ignored, but the exception string is printed, so the user can inspect the script afterwards to see which files are problematic and also gets the reason from the execption string. The idea is to read as much data as possible.

This is what I get when a file is not found:
6a82: Wrong parameters - File not found

This is what I get when I try to read from a file that requires ADM permissions:
Failed to read (offset 0)

Also I am now collecting the exception strings along with the filenames to print a summary at the end, so the errors can not hide anymore somewhere in the script comments.

If there were errors I now also raise an exception that tells the user that some files could not be exported so he can check the logs if required.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I82f3ce92cd91a5ed3c4884d62f6b22e9589c8a49
Gerrit-Change-Number: 23210
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Mar 2021 22:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210318/9b458660/attachment.htm>


More information about the gerrit-log mailing list