Change in pysim[master]: pySim-shell: add "dir" command.
gerrit-no-reply at lists.osmocom.org
Thu Mar 18 16:28:33 UTC 2021
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23207 )
Change subject: pySim-shell: add "dir" command.
Patch Set 5:
> Patch Set 1:
> Curious that you chouse "dir" over "ls".
> As you just extended the get_selectables() with a comprehensive set of flags, it makes sense to also expose this to the user. I would argue that "ls" or "dir" should always show all options by default (making it identical to tab completion) but there's either a separate command, or ls/dir itself, that allows fine-grained controls like "ls --fids" or "ls --apps".
I have extended the dir command so that we have a bit more control over what is displayed. I also found that the flag model needed some improvement.
I do not think that it is a good idea to display all selectable options. The problem I see/have is that the full listing with all its synonyms is overwhelming/distracting. I have added an --all parameter that displays everything like the tab completion would.
To view, visit https://gerrit.osmocom.org/c/pysim/+/23207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Mar 2021 16:28:33 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log