Change in libosmocore[master]: tlv: Fix length returned by t{l16, 16l}v_put

daniel gerrit-no-reply at lists.osmocom.org
Thu Mar 18 13:53:53 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23401 )

Change subject: tlv: Fix length returned by t{l16,16l}v_put
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> Did you check existing callers of these APIs to make sure are behaving as expecting before/after the change?

I checked in libosmocore and just rechecked other osmo-* projects and the return values are universally ignored (both of tlv_put and msgb_tlv_put). Tbh I don't see how the current return values could have ever been usable for any case (except where they evaluate to the correct pointer e.g. with t16lv_put and len 0).

Programs usually call a variant of msgb_tlv_put which uses the *_TLV_GROSS_LEN macros to advance the buffer (with msgb_put), so that calculation was and still is correct.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I268a7e11fb5dce67ce1bd7974ab86c4d2bd002f7
Gerrit-Change-Number: 23401
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Mar 2021 13:53:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210318/4d72be2b/attachment.htm>


More information about the gerrit-log mailing list