Change in osmo-bts[master]: osmo-bts-trx: fix segfault on trx_phy_inst_open() failure

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 18 10:57:45 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23399 )

Change subject: osmo-bts-trx: fix segfault on trx_phy_inst_open() failure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23399/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23399/1/src/osmo-bts-trx/trx_if.c@200 
PS1, Line 200: 	l1h->trx_ofd_ctrl.fd = -1;
what about if reopen happens (after some close?) Is that possible? In that case, are we resetting this to -1 again?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1f128813528f505fede04799e84456f6271058d0
Gerrit-Change-Number: 23399
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Mar 2021 10:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210318/50f487d1/attachment.htm>


More information about the gerrit-log mailing list