Change in pysim[master]: pySim-shell: add filesystem exporter

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 16 17:36:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23210 )

Change subject: pySim-shell: add filesystem exporter
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23210/4/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23210/4/pySim-shell.py@178 
PS4, Line 178: 			self._c
should we really just ignore erros in reading files? I think we need to check _why_ reading/selecting fails.  If the file doesn't exist, fine, let's ignore it and simply write "# file not found: %s".

But what if selecting failed due to insufficient privileges?  or the card actually reports an error while reading (for whatever reason)?

I think in those situations we should actually throw the exception, or alteernativel first save all other files and then raise an exception at the end.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I82f3ce92cd91a5ed3c4884d62f6b22e9589c8a49
Gerrit-Change-Number: 23210
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Mar 2021 17:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210316/bd894364/attachment.htm>


More information about the gerrit-log mailing list