Change in osmo-gsm-tester[master]: ms_srs: turn tx/rx_gain into INT and make them optional

pespin gerrit-no-reply at lists.osmocom.org
Tue Mar 16 17:11:09 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23349 )

Change subject: ms_srs: turn tx/rx_gain into INT and make them optional
......................................................................

ms_srs: turn tx/rx_gain into INT and make them optional

when they are greater than 0 they are written as config paramter.
if they are -1 they are disbaled and automatic gain calibration is
used.

Change-Id: I473ff3ae679784178574d2f76b612dbf77180490
---
M src/osmo_gsm_tester/obj/ms_srs.py
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved; Verified



diff --git a/src/osmo_gsm_tester/obj/ms_srs.py b/src/osmo_gsm_tester/obj/ms_srs.py
index df83c2a..f564519 100644
--- a/src/osmo_gsm_tester/obj/ms_srs.py
+++ b/src/osmo_gsm_tester/obj/ms_srs.py
@@ -39,8 +39,8 @@
         'additional_args[]': schema.STR,
         'airplane_t_on_ms': schema.INT,
         'airplane_t_off_ms': schema.INT,
-        'tx_gain': schema.UINT,
-        'rx_gain': schema.UINT,
+        'tx_gain': schema.INT,
+        'rx_gain': schema.INT,
         'freq_offset': schema.INT,
         }
     for key, val in RunNode.schema().items():
diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index a922dc8..0250f2b 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -39,8 +39,12 @@
 dl_earfcn = 2850
 % endif
 freq_offset = ${ue.freq_offset}
+% if int(ue.tx_gain) > 0:
 tx_gain = ${ue.tx_gain}
+% endif
+% if int(ue.rx_gain) > 0:
 rx_gain = ${ue.rx_gain}
+% endif
 
 #nof_radios = 1
 nof_antennas = ${ue.num_antennas}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23349
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I473ff3ae679784178574d2f76b612dbf77180490
Gerrit-Change-Number: 23349
Gerrit-PatchSet: 6
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210316/57a1ec99/attachment.htm>


More information about the gerrit-log mailing list