Change in osmo-sgsn[master]: main: resurrect removed 'ns' logging category as deprecated

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 15 16:20:01 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23363 )

Change subject: main: resurrect removed 'ns' logging category as deprecated
......................................................................

main: resurrect removed 'ns' logging category as deprecated

This logging category has been removed completely in [1], and now
osmo-sgsn fails to start with old configuration files:

  There is no such command.
  Error occurred during reading the below line:
   logging level ns info

Let's accept it and print a deprecation warning.

Change-Id: I2036170af41db89484c299e18e0b703c97427dc1
Fixes: [1] Ia4723ab344ad6a1927029a2d5d0dda020266b39d
---
M src/sgsn/sgsn_main.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c
index 97309dd..71f2efa 100644
--- a/src/sgsn/sgsn_main.c
+++ b/src/sgsn/sgsn_main.c
@@ -405,6 +405,7 @@
 	rate_ctr_init(tall_sgsn_ctx);
 
 	logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "bssgp");
+	logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "ns");
 
 	sgsn_nsi = gprs_ns2_instantiate(tall_sgsn_ctx, &gprs_ns_prim_cb, NULL);
 	if (!sgsn_nsi) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2036170af41db89484c299e18e0b703c97427dc1
Gerrit-Change-Number: 23363
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210315/a258d373/attachment.htm>


More information about the gerrit-log mailing list