Change in osmo-bsc[master]: Add command to enable RX diversity to RBS2000

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 15 10:04:26 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23318 )

Change subject: Add command to enable RX diversity to RBS2000
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/6/include/osmocom/bsc/abis_om2000.h 
File include/osmocom/bsc/abis_om2000.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/6/include/osmocom/bsc/abis_om2000.h@52 
PS6, Line 52: 	OM2K_RX_DIVERSITY_A	= 0x02,
This order of fields is really weird. Can we please have it in numerical order?
OM2K_RX_DIVERSITY_B	= 0x01.
OM2K_RX_DIVERSITY_A	= 0x02,
OM2K_RX_DIVERSITY_AB	= 0x03,



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I430762b8cfa51060841d90ba4446de73bd557c6c
Gerrit-Change-Number: 23318
Gerrit-PatchSet: 6
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Mar 2021 10:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210315/f9bb7290/attachment.htm>


More information about the gerrit-log mailing list