Change in osmo-bsc[master]: fix/refactor neighbor config

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 15 10:00:14 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23360 )

Change subject: fix/refactor neighbor config
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/1/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/1/include/osmocom/bsc/bts.h@501 
PS1, Line 501: 	 * An actual neighbor cell object (local or remote-BSS) is resolved "at runtime" whenever a neighbor is being
I would add some verification function at startup to make sure the config is valid.


https://gerrit.osmocom.org/c/osmo-bsc/+/23360/1/src/osmo-bsc/neighbor_ident.c 
File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/1/src/osmo-bsc/neighbor_ident.c@362 
PS1, Line 362: 	/* Is there a local BTS that matches the key? */
remove "local" from here, since it checks both now.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Mar 2021 10:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210315/d7f2e0c9/attachment.htm>


More information about the gerrit-log mailing list