Change in osmo-bsc[master]: Add command to enable RX diversity to RBS2000

keith gerrit-no-reply at lists.osmocom.org
Sat Mar 13 06:51:51 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23318 )

Change subject: Add command to enable RX diversity to RBS2000
......................................................................


Patch Set 6:

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@585 
PS4, Line 585: "Both\n"
> Right. again.. hangover from the first draft. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@597 
PS4, Line 597: if
> else if
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@599 
PS4, Line 599: if
> else if
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@682 
PS4, Line 682: const struct value_string om2k_rx_diversity_names[4] = {
> if it's not used outside of this file: use "static"
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@694 
PS4, Line 694: void abis_om2k_config_write_trx(struct vty *vty, struct gsm_bts_trx *trx)
> should also be static (and yes, the code below sets a wrong example, sorry))
I dunno... but maybe it's the right example?

bts_ericsson_rbs2000.c:177:

static void config_write_trx(struct vty *vty, struct gsm_bts_trx *trx)
{
	abis_om2k_config_write_trx(vty, trx);
}



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I430762b8cfa51060841d90ba4446de73bd557c6c
Gerrit-Change-Number: 23318
Gerrit-PatchSet: 6
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 13 Mar 2021 06:51:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210313/7b705ea1/attachment.htm>


More information about the gerrit-log mailing list